Comments on draft-ietf-ips-scsi-mib-04

["KRUEGER,MARJORIE (HP-Roseville,ex1)" <marjorie.krueger@hp.com>]

Thanks for all your work Michelle, this draft represents a lot of changes.
Some last minor edits:

1)Section 3.1, delete the next to the last paragraph:
 
"No development is currently planned for standard command-set-
 specific or device-specific MIBs."

It's redundant, that sentence is already included two paragraphs
before this paragraph.

2) sec. 3.3, second paragraph - the term "NMS" is used but not defined.  
suggest "network management station (NMS)" be substituted.

3) sections 4.1-4.13 suffer from some sort of formatting glitch -
the indentation implies some of these sections should be two paragraphs
but there is no separating blank line.

Actually, on further examination, the entire document seems to suffer
the same problem.

4) sec. 5, p1 first sentence, "depenency" should be "dependancy"

sec. 5 p3 - despite the claims of the first paragraph, this paragraph
doesn't contain the name of the table it is describing.  Should be
scsiIntrPrtTable?
		    
sec. 5, p 8 (starts "- The scsiAttTgtPortTable provides")  
Worded somewhat misleading (there is no connection-related information
in this table). I recommend rewording the first sentence to:

 - The scsiAttTgtPortTable provides information about the target
   ports each SCSI initiator port is currently communicating with. 

sec. 5 p 11 - "SCSITargetsPort" should be "scsiTgtPortTable"

sec. 5 last paragraph - first sentence should be:

"Provide a means to monitor all the SCSI initiator ports currently 
 attached to this SCSI target port."

5) ScsiName	TC- REFERENCE should be to SAM-2, not George's proposal
since Georges proposal is now an appendix in SAM-2

6)scsiInstAlias, scsiDeviceAlias, etc -why are these admin strings 
limited to 79 characters?  IMO, these SYNTAX should just be SnmpAdminString
w/no additional size limitation.

7) scsiDscLunEntry DESCRIPTION, last sentence is:

          Note that when an entry in the scsiDscTgtTable is deleted, 
          then any corresponding entries in this table is automatically 
          deleted." 

suggest changing to: 

          Note that when an entry in the scsiDscTgtTable is deleted, 
          all corresponding entries in this table should automatically 
          be deleted."
          
8) scsiDscLunLun - the discovered LUN number is a natural index for this
table, there is no need for another artificial index.  So this table 
should look like:

   scsiDscLunEntry OBJECT-TYPE 
     SYNTAX           ScsiDscLunEntry 
     MAX-ACCESS       not-accessible 
     STATUS           current 
     DESCRIPTION 
          "An entry (row) represents a discovered LUN at a particular 
          SCSI target device (scsiDscTgtIndex), where the LUN was 
          discovered by a particular local initiator device within a 
          particular SCSI instance, possibly via a particular local 
          initiator port. 
          Note that when an entry in the scsiDscTgtTable is deleted, 
          then any corresponding entries in this table is automatically 
          deleted." 
     INDEX { scsiInstIndex, scsiDeviceIndex, scsiDscTgtIntrPortIndex,   
     scsiDscTgtIndex, scsiDscLun } 
     ::= { scsiDscLunTable 1 } 
    
   ScsiDscLunEntry ::= SEQUENCE { 
     scsiDscLunLun       ScsiLUN   
   } 
    
   scsiDscLun OBJECT-TYPE 
     SYNTAX         ScsiLUN 
     MAX-ACCESS     not-accessible 
     STATUS         current 
     DESCRIPTION 
          "This object contains the Logical Unit Number (LUN) of the 
          discovered logical unit."
     ::= { scsiDscLunEntry 1 } 

I think Mark already commented on the fact that the SYNTAX and 
DESCRIPTION need not call out any special attention to a zero value
since all targets have LUN 0.

This change requires an index name change to scsiDscLunIdTable too.

9) formatting nit:  the comment before scsiTgtDevTable is formatted 
differently than the comments preceeding the other tables.  It is:

   -- Management Objects regarding target type of scsi devices 
   --  

and other comments are formatted like:
-- ********* Table of **********

10) The scsiAuthorizedIntrTable description should explain that if 
scsiAuthIntrTgtPortIndex is zero, it means that this entry pertains to
all target ports on the device identified by scsiDeviceIndex.

11)scsiAuthIntrWrittenMegaBytes DESCRIPTION should be:

          "This object indicates the amount of data in Megabytes that 
          the remote initiator corresponding to this entry has written 
          to the local target device or port corresponding to this 
          entry." 

12)scsiLuWrittenMegaBytes DESCRIPTION should be:
          " This object represents the amount of data in Megabytes 
          written to this logical unit." 
	

13)scsiLuOutQueueFullStatus	DESCRIPTION should be:
          " This object represents the number of queue full statuses 
          issued for this logical unit."